[PATCH] D22834: Added 'inline' attribute to basic_string's destructor
Aditya Kumar via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 12 11:35:47 PDT 2016
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchmarks
> http://github.com/google/benchmark
>
> Let me know if I can help.
Hi Eric,
Is this also good to merge.
Thanks,
-Aditya
https://reviews.llvm.org/D22834
More information about the cfe-commits
mailing list