[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

[Ben Harper via cfe-commits]

PING.

Is there anything I can do to make reviewing easier?

For example, I could run my code vs master on some large code bases (eg
linux kernel, chromium), and verify that there are no crashes, and also
manually spot check some results.

Ben

On Wed, 20 Jul 2016 at 21:43 Ben Harper <rogojin at gmail.com> wrote:

> bmharper added a comment.
>
> PING
>
>
> ================
> Comment at: lib/Format/WhitespaceManager.cpp:95
> @@ -97,2 +94,3 @@
>    std::sort(Changes.begin(), Changes.end(),
> Change::IsBeforeInFile(SourceMgr));
> +  calculateScopeLevel();
>    calculateLineBreakInformation();
> ----------------
> berenm wrote:
> > Maybe we could spare the computation if we aren't going to align
> anything?
> >
> > Is it better for clarity to always compute additional information?
> @djasper what's the Clang way to do?
> >
> That's a good point. One certainly could elide that if alignment was
> turned off. I think so long as it was mentioned in the comments of the
> ScopeLevel member variable, it would be OK to do so. However, I'll also
> just defer this decision to @djasper.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D21279
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160811/30f5e66f/attachment.html>