[PATCH] D23204: Visit lambda capture inits from RecursiveASTVisitor::TraverseLambdaCapture().

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 06:54:46 PDT 2016


klimek added inline comments.

================
Comment at: include/clang/AST/RecursiveASTVisitor.h:892
@@ -891,1 +891,3 @@
+  else
+    TRY_TO(TraverseStmt(LE->capture_init_begin()[C - LE->capture_begin()]));
   return true;
----------------
I'd rather pass in the offset than doing math with what's semantically a pointer vs an iterator.

================
Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:236
@@ +235,3 @@
+TEST(RecursiveASTVisitor, VisitsLambdaInitCaptureInit) {
+  {
+    DeclRefExprVisitor Visitor;
----------------
I'd remove the extra scope.


https://reviews.llvm.org/D23204





More information about the cfe-commits mailing list