[PATCH] D23265: [clang-tidy] enhance readability-else-after-return

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 10 05:26:15 PDT 2016


aaron.ballman added inline comments.

================
Comment at: docs/clang-tidy/checks/readability-else-after-return.rst:14
@@ -8,2 +13,3 @@
 
-http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return
+``` c++
+void foo(int Value) {
----------------
alexfh wrote:
> aaron.ballman wrote:
> > aaron.ballman wrote:
> > > Since we're talking about LLVM coding conventions, can you format this like LLVM code (elide braces, etc)?
> > This is not the proper way to introduce a code block. Should use `.. code-block:: c++` and then indent the code blocks.
> I think, the braces are fine, since the example needs to demonstrate that the check is able to remove them.
Okay, that's a fair, but subtle, reason to leave them in.


https://reviews.llvm.org/D23265





More information about the cfe-commits mailing list