[PATCH] D18073: Add memory allocating functions

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 9 05:58:08 PDT 2016


On Mon, Aug 8, 2016 at 8:13 PM, Alexander Riccio <alexander at riccio.com> wrote:
> ariccio added a comment.
>
> In https://reviews.llvm.org/D18073#504216, @dcoughlin wrote:
>
>> No. The identifier info will be null for C++ operators.
>
>
> I assume you mean `operator new/new[]/delete/delete[]

Correct.

~Aaron

>
>> > Thus, when`! isWindowsMSVCEnvironment`, I leave the Windows-only memory allocating functions initialized to `nullptr`, which will never equal a non-null `IdentifierInfo*`, and never trigger on a non-Windows platform.
>
>>
>
>>
>
>> It is probably better to be explicit about this.
>
>
>
>
>
> https://reviews.llvm.org/D18073
>
>
>


More information about the cfe-commits mailing list