[PATCH] D23266: [include-fixer] Support processing multiple files in one run.

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 8 08:27:28 PDT 2016


bkramer added a comment.

Can you add a lit test for this? We should've added that earlier :|


================
Comment at: include-fixer/IncludeFixer.h:53
@@ -51,2 +52,3 @@
 
   /// The context that contains all information about the symbol being queried.
+  std::vector<IncludeFixerContext> &Contexts;
----------------
This comment is now outdated, there are multiple contexts.

================
Comment at: include-fixer/IncludeFixerContext.h:21
@@ -20,2 +20,3 @@
 
-/// \brief A context for the symbol being queried.
+/// \brief A context for the file being processed. It includes all query
+/// information, e.g. symbols being queried in database, all header candiates.
----------------
A context for **a** file being processed.

================
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
 
+  /// \brief The absolute path to the file being processed.
+  std::string FilePath;
----------------
Does it have to be absolute?


https://reviews.llvm.org/D23266





More information about the cfe-commits mailing list