[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.
Jonas Hahnfeld via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 5 02:07:22 PDT 2016
Hahnfeld added a comment.
Any chance we can get this fixed?
================
Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:89-95
@@ +88,9 @@
+ }
+ if (ec) {
+ assert(old_write_time == new_write_time);
+ return false;
+ } else {
+ assert(new_write_time <= -5);
+ return true;
+ }
+}
----------------
Hahnfeld wrote:
> Obviously, I meant this part of the code, sorry:
> > Hmm no, this doesn't work for me: `fs::last_write_time` just takes the negative timestamp and overflows somewhere internally...
Maybe we can use `if (ec && new_write_time <= -5)`?
https://reviews.llvm.org/D22452
More information about the cfe-commits
mailing list