[PATCH] D23158: [clang-rename] merge tests when possible

[Alexander Kornienko via cfe-commits]

alexfh added a comment.

Awesome! A few improvements are still possible though. See inline comments.


================
Comment at: test/clang-rename/ClassAsTemplateArgument.cpp:15
@@ +14,3 @@
+
+// RUN: cat %s > %t_0.cpp
+// RUN: clang-rename -offset=7 -new-name=Bar %t_0.cpp -i --
----------------
Since clang-rename can output the result to stdout, it makes sense to avoid copying files and switch to a single pipeline for each test case.

================
Comment at: test/clang-rename/ClassAsTemplateArgument.cpp:16
@@ +15,3 @@
+// RUN: cat %s > %t_0.cpp
+// RUN: clang-rename -offset=7 -new-name=Bar %t_0.cpp -i --
+// RUN: sed 's,//.*,,' %t_0.cpp | FileCheck %s
----------------
Please add instruction on how to find offsets (something along the lines of "n-th line of grep -b Foo test-file.cpp").


https://reviews.llvm.org/D23158