[PATCH] D22834: Added 'inline' attribute to basic_string's destructor

Tue Aug 2 22:45:59 PDT 2016

On Sat, Jul 30, 2016 at 1:47 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> On Tue, Jul 26, 2016 at 10:30:22PM +0000, Laxman Sole via cfe-commits
> wrote:
> > Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string().
>
> Does this change the ABI?
>

No. Clang still externally instantiates the dtor in the dylib because the
'_LIBCPP_INLINE_VISIBILITY` attribute is not applied to the declaration.
However adding the attribute to the out-of-line definition allows Clang to
generate inline dtor calls.

>
> Joerg
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160802/bb9d70f6/attachment.html>