[PATCH] D22431: clang-format: [JS] nested and tagged template strings.

Daniel Jasper via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 04:49:10 PDT 2016


djasper added inline comments.

================
Comment at: lib/Format/FormatTokenLexer.cpp:254
@@ +253,3 @@
+  for (; Offset != Lex->getBuffer().end(); ++Offset) {
+    if (*Offset == '`') {
+      StateStack.pop();
----------------
I'd use Offset[0]

================
Comment at: lib/Format/FormatTokenLexer.h:85
@@ -68,2 +84,3 @@
   bool GreaterStashed, LessStashed;
+  std::stack<LexerState> StateStack;
   unsigned Column;
----------------
Should we also use this for GreaterStashed and LessStashed?


https://reviews.llvm.org/D22431





More information about the cfe-commits mailing list