[PATCH] D23006: [clang-rename] add basic Emacs integration

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 2 00:59:03 PDT 2016


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

lgtm with two nits.


================
Comment at: clang-rename/tool/CMakeLists.txt:14
@@ +13,3 @@
+
+install(PROGRAMS clang-rename.el
+  DESTINATION share/clang
----------------
Also include the vim integration clang-rename.py?

================
Comment at: docs/clang-rename.rst:99
@@ -98,3 +98,3 @@
 Once installed, you can point your cursor to symbols you want to rename, press
-``<leader>cr`` and print new desired name. The
-[``<leader> key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+`<leader>cr` and print new desired name. The [`<leader> key`]
+(http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
----------------
s/print/type


https://reviews.llvm.org/D23006





More information about the cfe-commits mailing list