r277396 - Add FIXMEs for MSVC 2013 hacks in r277211. NFC.

Paul Robinson via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 15:12:46 PDT 2016


Author: probinson
Date: Mon Aug  1 17:12:46 2016
New Revision: 277396

URL: http://llvm.org/viewvc/llvm-project?rev=277396&view=rev
Log:
Add FIXMEs for MSVC 2013 hacks in r277211. NFC.

Modified:
    cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp

Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp?rev=277396&r1=277395&r2=277396&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Mon Aug  1 17:12:46 2016
@@ -5489,6 +5489,7 @@ public:
       Info[VD].push_back({L, MapType, MapModifier, ReturnDevicePointer});
     };
 
+    // FIXME: MSVC 2013 seems to require this-> to find member CurDir.
     for (auto *C : this->CurDir.getClausesOfKind<OMPMapClause>())
       for (auto L : C->component_lists())
         InfoGen(L.first, L.second, C->getMapType(), C->getMapTypeModifier(),
@@ -5506,6 +5507,7 @@ public:
     // entries as such. If there is no map information for an entry in the
     // use_device_ptr list, we create one with map type 'alloc' and zero size
     // section. It is the user fault if that was not mapped before.
+    // FIXME: MSVC 2013 seems to require this-> to find member CurDir.
     for (auto *C : this->CurDir.getClausesOfKind<OMPUseDevicePtrClause>())
       for (auto L : C->component_lists()) {
         assert(!L.second.empty() && "Not expecting empty list of components!");
@@ -5538,6 +5540,7 @@ public:
 
         // We didn't find any match in our map information - generate a zero
         // size array section.
+        // FIXME: MSVC 2013 seems to require this-> to find member CGF.
         llvm::Value *Ptr =
             this->CGF
                 .EmitLoadOfLValue(this->CGF.EmitLValue(IE), SourceLocation())
@@ -5558,6 +5561,7 @@ public:
 
         // Remember the current base pointer index.
         unsigned CurrentBasePointersIdx = BasePointers.size();
+        // FIXME: MSVC 2013 seems to require this-> to find the member method.
         this->generateInfoForComponentList(L.MapType, L.MapTypeModifier,
                                            L.Components, BasePointers, Pointers,
                                            Sizes, Types, IsFirstComponentList);
@@ -5637,6 +5641,7 @@ public:
       return;
     }
 
+    // FIXME: MSVC 2013 seems to require this-> to find member CurDir.
     for (auto *C : this->CurDir.getClausesOfKind<OMPMapClause>())
       for (auto L : C->decl_component_lists(VD)) {
         assert(L.first == VD &&




More information about the cfe-commits mailing list