[PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

[Anastasia Stulova via cfe-commits]

Hi Xiuli,

Could you please elaborate what do you think it broken exactly?

Because we haven't actually removed opencl.kernels metadata but just changed the format of it. 

Basically, we are using function metadata instead of generic metadata as it was before.

Thanks,
Anastasia

-----Original Message-----
From: Pan Xiuli [mailto:xiulipan at outlook.com] 
Sent: 01 August 2016 05:54
To: reviews+D20979+public+e2872c9c869f1bc7 at reviews.llvm.org; Anastasia Stulova; alexey.bader at intel.com
Cc: thomas.stellard at amd.com; cfe-commits at lists.llvm.org
Subject: RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

Hi Sam,

I am now using llvm39 to enable our opencl driver, but I found this patch broke the spir target as well.
The opencl.kernels metadata is required by spir spec. I think we should keep the old code for spir target.

Thanks
Xiuli

-----Original Message-----
From: Yaxun Liu [mailto:yaxun.liu at amd.com] 
Sent: Wednesday, June 22, 2016 11:04 PM
To: yaxun.liu at amd.com; xiulipan at outlook.com; anastasia.stulova at arm.com; alexey.bader at intel.com
Cc: thomas.stellard at amd.com; cfe-commits at lists.llvm.org
Subject: Re: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

This revision was automatically updated to reflect the committed changes.
Closed by commit rL273425: [OpenCL] Use function metadata to represent kernel attributes (authored by yaxunl).

Changed prior to commit:
  http://reviews.llvm.org/D20979?vs=60545&id=61555#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D20979

Files:
  cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
  cfe/trunk/test/CodeGenOpenCL/kernel-arg-info.cl
  cfe/trunk/test/CodeGenOpenCL/kernel-attributes.cl
  cfe/trunk/test/CodeGenOpenCL/kernel-metadata.cl