[PATCH] D23006: [clang-rename] add basic Emacs integration

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 10:29:55 PDT 2016


omtcyfz marked 2 inline comments as done.

================
Comment at: clang-rename/tool/clang-rename.el:28
@@ +27,3 @@
+        (orig-buf (current-buffer))
+        (file-name (buffer-file-name)))
+
----------------
alexfh wrote:
> For posterity, please add a short summary of the offline discussion.
`call-process-region` is used while contents of current buffer are to be replaced, but in case of `clang-rename` changes might affect all buffers, which doesn't make sense to take care of one buffer only.


https://reviews.llvm.org/D23006





More information about the cfe-commits mailing list