[PATCH] D23006: [clang-rename] add basic Emacs integration

[Alexander Kornienko via cfe-commits]

alexfh added inline comments.

================
Comment at: clang-rename/tool/clang-rename.el:18
@@ +17,3 @@
+
+(defun clang-rename-upstream (new-name)
+  "Rename all instances of the symbol at the point using clang-rename"
----------------
The name should be just "clang-rename".

================
Comment at: docs/clang-rename.rst:100
@@ +99,3 @@
+`<leader>cr` and print new desired name. The
+[`<leader> key`]
+(http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
----------------
Remove the linebreak after "The".

================
Comment at: docs/clang-rename.rst:114
@@ +113,3 @@
+Once installed, you can point your cursor to symbols you want to rename, press
+`M-X`, print `clang-rename` and new desired name.
+
----------------
hokein wrote:
> `print` doesn't make sense here? I think user should type `clang-rename` and new name.
Yep, just s/print/type/.


https://reviews.llvm.org/D23006