[PATCH] D22513: [clang-tidy] add check cppcoreguidelines-special-member-functions

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 05:22:02 PDT 2016


On Mon, Aug 1, 2016 at 6:48 AM, Jonathan Coe <jbcoe at me.com> wrote:
> Thanks for reporting this.
>
> I can reproduce the segfault and have a fix. Is it ok to commit and have
> review done later?

Yes, this sort of thing is typical to handle post-commit (along with
other feedback that comes in post-commit).

~Aaron

>
> regards,
>
> Jon
>
> On 1 August 2016 at 11:06, Eric Lemanissier <eric.lemanissier at gmail.com>
> wrote:
>>
>> ericLemanissier added a comment.
>>
>> I have an segfault on all the source files of my project when I enable
>> this check (it works ok when I disable this check). Sorry I don't have time
>> to post a minimal source file producing the segfault. I will maybe tomorrow,
>> or in two weeks.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D22513
>>
>>
>>
>>
>


More information about the cfe-commits mailing list