[PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 1 04:10:55 PDT 2016


rengolin added a reviewer: compnerd.
rengolin added a subscriber: compnerd.
rengolin added a comment.

Can you add a test on test/Headers, like the others, please?

I'm not well versed on Windows. @compnerd?


================
Comment at: lib/Headers/armintr.h:1
@@ +1,2 @@
+/*===---- armintr.h - ARM intrinsics ---------------------------------------===
+ *
----------------
Maybe a hint that this is "ARM Windows Intrinsics"?

================
Comment at: lib/Headers/armintr.h:27
@@ +26,3 @@
+
+typedef enum
+{
----------------
Maybe an ifdef Windows wrapper, to make sure not to mess up *nix environments?


https://reviews.llvm.org/D22774





More information about the cfe-commits mailing list