[PATCH] D21814: clang-rename: split existing options into two new subcommands

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 29 09:11:46 PDT 2016


omtcyfz added a comment.

In https://reviews.llvm.org/D21814#500629, @vmiklos wrote:

> In https://reviews.llvm.org/D21814#500621, @omtcyfz wrote:
>
> > P.S. not sure whether we have to write `clang-rename: for the -new-name option: must be specified` out. We already launched `clang-rename` what else could've give us an error?
>
>
> You mean how is that error produced? Previously there was no `cl::Required` on NewName (now: NewNames), and that's why a manual check was needed, the error message changed, as now the option parser does this checking for us.


Ah, I see. So the message is generated, isn't it?


https://reviews.llvm.org/D21814





More information about the cfe-commits mailing list