[PATCH] D22666: Frontend: Fix mcount inlining bug

[Hal Finkel via cfe-commits]

hfinkel added a comment.

In https://reviews.llvm.org/D22666#500338, @honggyu.kim wrote:

> In https://reviews.llvm.org/D22666#500329, @hfinkel wrote:
>
> > In this case, I think that making a simple test (changing the current test to be) like test/CodeGen/stackrealign.c would be fine. If you have any questions, please feel free to ask.
>
>
> Thanks. Please correct me if I'm wrong.
>
>   diff --git a/test/CodeGen/mcount.c b/test/CodeGen/mcount.c
>   index 99dc907..31b5288 100644
>   --- a/test/CodeGen/mcount.c
>   +++ b/test/CodeGen/mcount.c
>   @@ -13,6 +13,7 @@
>    // RUN: %clang_cc1 -pg -triple sparc-netbsd -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-PREFIXED %s
>    // RUN: %clang_cc1 -pg -triple sparc64-netbsd -emit-llvm -o - %s | FileCheck -check-prefix=CHECK-PREFIXED %s
>    void foo(void) {
>   -// CHECK: call void @mcount()
>   -// CHECK-PREFIXED: call void @_mcount()
>    }
>   +
>   +// CHECK: attributes #{{[0-9]+}} = { "counting-function"="mcount" {{.*}} }


Both of the RUN lines have --check=CHECK-PREFIXED; does anything actually use the above CHECK: line? Maybe you just want to have one CHECK: line, associated with the comment with -pg, and one CHECK-NOT: line, associated with a command line without -pg.

> +// CHECK-PREFIXED: attributes #{{[0-9]+}} = { "counting-function"="_mcount" {{.*}} }

> 

>   





https://reviews.llvm.org/D22666