[PATCH] D22666: Frontend: Fix mcount inlining bug

Hal Finkel via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 28 20:38:46 PDT 2016


hfinkel added a comment.

In https://reviews.llvm.org/D22666#500328, @honggyu.kim wrote:

> In https://reviews.llvm.org/D22666#500327, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D22666#500326, @honggyu.kim wrote:
> >
> > > Should we also modify clang/test/CodeGen/mcount.c as well?  I'm not actually familiar with test infra.
> >
> >
> > Yes, you'll need to modify it to test for the attribute instead.
>
>
> Thanks. As I mentioned, I don't know about the test infra well so can you please give me some guide to check the attribute? I will learn this time and do it myself next time.


In this case, I think that making a simple test (changing the current test to be) like test/CodeGen/stackrealign.c would be fine. If you have any questions, please feel free to ask.


https://reviews.llvm.org/D22666





More information about the cfe-commits mailing list