[PATCH] D22824: MathExtras.h: add LLVM_CONSTEXPR where simple
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 28 07:42:53 PDT 2016
aaron.ballman added inline comments.
================
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
----------------
Usually preferred to put in && "rationale goes here" for asserts (here and elsewhere).
Were these changes expected, as they don't seem to relate to constexpr?
https://reviews.llvm.org/D22824
More information about the cfe-commits
mailing list