[PATCH] D22668: TrailingObjects::FixedSizeStorage constexpr fixes

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 28 07:21:10 PDT 2016


aaron.ballman added a comment.

I don't suppose there's a way to test these changes, is there?


================
Comment at: include/llvm/Support/MathExtras.h:682
@@ +681,3 @@
+
+// alignTo for contexts where a constant expression is required.
+// FIXME: remove when LLVM_CONSTEXPR becomes really constexpr
----------------
Switch to use doxygen-style comments?

================
Comment at: include/llvm/Support/TrailingObjects.h:149
@@ -148,1 +148,3 @@
 
+  struct RequiresRealignment {
+    static const bool value =
----------------
Does this need to be public?


https://reviews.llvm.org/D22668





More information about the cfe-commits mailing list