[PATCH] D22881: Fix NamedDeclFindingASTVisitor

[Kirill Bobyrev via cfe-commits]

omtcyfz added a comment.

In https://reviews.llvm.org/D22881#498919, @alexshap wrote:

> i took a look at handleNestedNameSpecifierLoc:
>
>   const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
>   if (Decl) {
>    setResult(Decl, NameLoc.getLocalBeginLoc(), NameLoc.getLocalEndLoc());
>   }
>


Yes, that's why if something happens twice in the codebase, it should be moved to the other place :)

> and added this check to VisitTypeLoc.

> 

> the other Visit* methods are:

>  VisitNamedDecl(const NamedDecl *Decl)

>  VisitDeclRefExpr(const DeclRefExpr *Expr)

>  VisitMemberExpr(const MemberExpr *Expr)


Yes, I am aware of that.


https://reviews.llvm.org/D22881