[PATCH] D22857: [ARM] Add a test for inline assembly when targeting armv7-windows

Renato Golin via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 27 08:58:29 PDT 2016


rengolin added a comment.

In https://reviews.llvm.org/D22857#497805, @ahatanak wrote:

> Is r276859 fixing a bug in the assembler?


Sort of. It was just adding a comment character to ; instead of #.

> I'm trying to understand why we have to add a clang test in this particular case because I don't think we normally add a test in clang every time we fix a bug in the backend or assembler.


As I read it, this is just making sure "inline asm" works on Windows, which apparently hasn't been working so far. In a way, unrelated to the commit in question.

I agree we shouldn't be adding clang tests to assembler bugs.


https://reviews.llvm.org/D22857





More information about the cfe-commits mailing list