[PATCH] D22766: Handle -mlong-calls on Hexagon

[Eric Christopher via cfe-commits]

echristo added a comment.

Why isn't the existing +long-calls handling good enough (other than making it a generic option rather than arm specific)? You don't seem to be using any of the code in Targets.cpp to do anything.

Also a couple of random comments inline on the patch.

-eric


================
Comment at: lib/Basic/Targets.cpp:6236-6239
@@ -6229,1 +6235,6 @@
+
+    if (F == "+long-calls")
+      UseLongCalls = true;
+    else if (F == "-long-calls")
+      UseLongCalls = false;
   }
----------------
This seems to be overly complex.

================
Comment at: lib/Basic/Targets.cpp:6257-6263
@@ +6256,9 @@
+      StringRef Name, bool Enabled) const {
+  if (Enabled) {
+    if (Name == "hvx-double")
+      Features["hvx"] = true;
+  } else {
+    if (Name == "hvx")
+      Features["hvx-double"] = false;
+  }
+  Features[Name] = Enabled;
----------------
This appears to be unrelated?


Repository:
  rL LLVM

https://reviews.llvm.org/D22766