[PATCH] D22637: [OpenCL] Add extension cl_khr_mipmap_image to clang

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning at +6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}}
+#else
----------------
ashi1 wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > Can you move this error message down instead of adding 6 lines offset.
> > > Also the extension seems to be set by default although it's hard to see without the full diff. So why do you get this warning at all?
> > This warning is only for opencl version < 200. The extension is supported by OpenCL 2.0 and above only.
> I've added this error message here because I am following the order inside include/clang/Basic/OpenCLExtensions.def. Seems it is alphabetical there and in same order here. What do you think?
This warning is to line 194 which is an else from:

  #if (__OPENCL_C_VERSION__ < 200)

hence OpenCL >= 2.0. There should be no warning in this case?

================
Comment at: test/SemaOpenCL/extension-version.cl:228
@@ +227,3 @@
+#endif
+// expected-warning at +6{{unsupported OpenCL extension 'cl_khr_mipmap_image' - ignoring}}
+#else
----------------
ashi1 wrote:
> Anastasia wrote:
> > Can you move this error message down instead of adding 6 lines offset.
> I've added this error message here because I am following the order inside include/clang/Basic/OpenCLExtensions.def. Seems it is alphabetical there and in same order here. What do you think?
Sure that's great! I am just saying could you move the expected-warning line below to where it belongs i.e. line 234 where you are enabling the extension which results in a warning generated.


Repository:
  rL LLVM

https://reviews.llvm.org/D22637