[PATCH] D22470: [libcxx] Improve shared_ptr dtor performance

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 24 22:51:39 PDT 2016


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you for the thorough doc. It sure made the review easy on my end.

I took the liberty of rewriting your 3 benchmarks to use Google Benchmark: https://gist.github.com/EricWF/6ab9d3ca9315f2dcf8b0b8a7e47a9ac8
I'm hoping to have a singular benchmark format so it's easier to write tooling for. Here are the docs for building libc++'s benchmarks. <http://libcxx.llvm.org/docs/TestingLibcxx.html#benchmarks>


https://reviews.llvm.org/D22470





More information about the cfe-commits mailing list