[PATCH] D21814: clang-rename: split existing options into two new subcommands

Miklos Vajna via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 22 02:02:33 PDT 2016


vmiklos added a comment.

In https://reviews.llvm.org/D21814#492540, @omtcyfz wrote:

> I'd be actually happy if instead of having `-rename-at` option we'd have this behavior by default unless `-rename-all` is used.


Not sure I understand this request. rename-at and rename-all all subcommands, not options. "have this by default", you mean the ability to perform multiple oldname->newname replacements with one commandline invocation? If so, not allowing that when the rename-all subcommand is chosen sounds confusing to me. But perhaps I misunderstand something. ;-)

I can make the rename-at subcommand optional, and when not specifying a subcommand, assume rename-at was specified (unless -help or -version is used). Is this what you want?


https://reviews.llvm.org/D21814





More information about the cfe-commits mailing list