[PATCH] D22593: [Profile] document %h and %m

[David Li via cfe-commits]

davidxl added inline comments.

================
Comment at: docs/UsersManual.rst:1500
@@ +1499,3 @@
+   name.  When this specifier is used, the profiler runtime will substitute ``%m``
+   with a unique integer identifier associated with the instrumented binary. Multiple
+   profiles dumped from different processes (running on the same or different hosts)
----------------
silvas wrote:
> I would suggest saying `Additionally, multiple...` instead of just `Multiple` to highlight that this is an additional behavior that is caused by using `%m`.
Done.

================
Comment at: docs/UsersManual.rst:1501
@@ +1500,3 @@
+   with a unique integer identifier associated with the instrumented binary. Multiple
+   profiles dumped from different processes (running on the same or different hosts)
+   will be automatically merged by the profiler runtime during the dumping. If
----------------
silvas wrote:
> You probably want to say "raw profiles" instead of just "profile" to clarify that this is a different sense of "merge" than `llvm-profdata merge ...` (or otherwise clarify).
Done. I also added another sentence clarifying it.


https://reviews.llvm.org/D22593