[PATCH] D22596: Retry: [Driver] Compute effective target triples once per job (NFCI)

Mehdi AMINI via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 20 15:16:24 PDT 2016


mehdi_amini added inline comments.

================
Comment at: include/clang/Driver/ToolChain.h:71
@@ -70,2 +70,3 @@
   const llvm::Triple Triple;
+  mutable llvm::Triple EffectiveTriple;
   const llvm::opt::ArgList &Args;
----------------
Documentation would be appreciated, a mutable field is never trivial to me.

================
Comment at: include/clang/Driver/ToolChain.h:145
@@ -143,1 +144,3 @@
 
+  /// \brief Set the toolchain's effective clang triple.
+  void setEffectiveTriple(llvm::Triple ET) const { EffectiveTriple = ET; }
----------------
No brief.


https://reviews.llvm.org/D22596





More information about the cfe-commits mailing list