[PATCH] D22567: [include-fixer] Add mising qualifiers to all instances of an unidentified symbol.
Benjamin Kramer via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 20 06:51:20 PDT 2016
bkramer added inline comments.
================
Comment at: include-fixer/IncludeFixer.cpp:246
@@ +245,3 @@
+ if (!QuerySymbolInfos.empty()) {
+ if (ScopedQualifiers.str() == QuerySymbolInfos.front().ScopedQualifiers &&
+ Query.str() == QuerySymbolInfos.front().RawIdentifier) {
----------------
Drop .str() when comparing StringRef with std::string.
================
Comment at: include-fixer/IncludeFixerContext.h:73
@@ -64,1 +72,3 @@
+ /// \brief The information of the symbol being queried.
+ std::vector<QuerySymbolInfo> QuerySymbolInfos;
----------------
This comment is rather useless as-is, maybe explain what it means to have multiple elements in the vector.
https://reviews.llvm.org/D22567
More information about the cfe-commits
mailing list