[PATCH] D20168: [CodeGen] Handle structs directly in AMDGPUABIInfo

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 19 11:22:24 PDT 2016


arsenm added inline comments.

================
Comment at: lib/CodeGen/TargetInfo.cpp:6856
@@ +6855,3 @@
+  }
+  else if (StrTy->getNumElements() == 1) {
+    // Coerce single element structs to its element.
----------------
No else after return

================
Comment at: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl:62
@@ +61,3 @@
+// CHECK-LABEL: @test_non_kernel_struct_arg
+// CHECK-NOT: %struct.struct_arg %arg1.coerce
+void test_non_kernel_struct_arg(struct_arg_t arg1)
----------------
Positive checks are greatly preferred 


https://reviews.llvm.org/D20168





More information about the cfe-commits mailing list