[PATCH] D22292: [libunwind] Fix unw_getcontext for ARMv6-m

Weiming Zhao via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 12:06:05 PDT 2016


weimingz added inline comments.

================
Comment at: src/UnwindRegistersRestore.S:326
@@ +325,3 @@
+#if !defined(__ARM_ARCH_ISA_ARM) && __ARM_ARCH_ISA_THUMB == 1
+  @ r8-r12: ldr into r1-r5, then mov to r8-r12
+  ldr r1, [r0, #0x20]
----------------
weimingz wrote:
> originally, r0-r7 get loaded from [r0]
> now, r8-r12 get loaded from [r0+0x20]
> 
> is that expected? 
> 
Please ignore the comment on line 326. I thought the “x" icon will delete it.


https://reviews.llvm.org/D22292





More information about the cfe-commits mailing list