r275377 - Use hasFlag instead of hasArg

David Blaikie via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 18 11:28:40 PDT 2016


What build problem did this cause? Did this just not compile (it looks as
if ArgList has hasArg and hasFlag, so I'm not sure what the specific
problem might've been)

On Wed, Jul 13, 2016 at 11:45 PM Dean Michael Berris via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Author: dberris
> Date: Thu Jul 14 01:37:46 2016
> New Revision: 275377
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275377&view=rev
> Log:
> Use hasFlag instead of hasArg
>
> Summary: Fix the build to use hasFlag instead of hasArg for checking some
> flags.
>
> Reviewers: echristo
>
> Subscribers: mehdi_amini, cfe-commits
>
> Differential Revision: http://reviews.llvm.org/D22338
>
> Modified:
>     cfe/trunk/lib/Driver/Tools.cpp
>
> Modified: cfe/trunk/lib/Driver/Tools.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=275377&r1=275376&r2=275377&view=diff
>
> ==============================================================================
> --- cfe/trunk/lib/Driver/Tools.cpp (original)
> +++ cfe/trunk/lib/Driver/Tools.cpp Thu Jul 14 01:37:46 2016
> @@ -4609,8 +4609,8 @@ void Clang::ConstructJob(Compilation &C,
>
>    Args.AddAllArgs(CmdArgs, options::OPT_finstrument_functions);
>
> -  if (Args.hasArg(options::OPT_fxray_instrument,
> -                  options::OPT_fnoxray_instrument, false)) {
> +  if (Args.hasFlag(options::OPT_fxray_instrument,
> +                   options::OPT_fnoxray_instrument, false)) {
>      CmdArgs.push_back("-fxray-instrument");
>      if (Arg *A =
> Args.getLastArg(options::OPT_fxray_instruction_threshold_,
>
> options::OPT_fxray_instruction_threshold_EQ)) {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160718/6931b7fa/attachment.html>


More information about the cfe-commits mailing list