[PATCH] D21329: Rename and rework `_LIBCPP_TRIVIAL_PAIR_COPY_CTOR`. Move FreeBSD configuration in-tree.

[Eric Fiselier via cfe-commits]

EricWF added a comment.

I'm committing this today, meaning it will make it into 3.9, so don't forget to remove your upstream patches before the release :-)

In https://reviews.llvm.org/D21329#476455, @dim wrote:

> In https://reviews.llvm.org/D21329#475105, @theraven wrote:
>
> > Looks fine to me, though I wonder if we want to move to the new ABI for FreeBSD11 and use the old one for <=10.
>
>
> For 11 it is certainly too late now, since it is ABI/API frozen now, and we would still need to find some way of providing backwards compat for applications that were linked against the earlier libc++, which still had the non-trivial pair copy constructor.


I can't think of any way to offer backwards compat for this particular ABI break. Looks like FreeBSD is stuck with this until your allowed to take a total ABI break. Does FreeBSD have a plan for when this might happen?


https://reviews.llvm.org/D21329