[PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

[Kelvin Li via cfe-commits]

I will take a look and put up a patch for it.

Kelvin

On Fri, Jul 15, 2016 at 2:46 AM, Alexey Bataev <a.bataev at hotmail.com> wrote:

> Kelvin,
> Please look at these messages and fix the tests. Or tell me and I will
> fix them
>
> Best regards,
> Alexey Bataev
> =============
> Software Engineer
> Intel Compiler Team
>
> 15.07.2016 9:23, Robinson, Paul пишет:
> >
> >> -----Original Message-----
> >> From: Alexey Bataev [mailto:a.bataev at hotmail.com]
> >> Sent: Thursday, July 14, 2016 7:51 PM
> >> To: reviews+d22096+public+4c00789034d62932 at reviews.llvm.org
> >> Cc: cfe-commits at lists.llvm.org; kkwli0 at gmail.com; cbertol at us.ibm.com;
> >> sfantao at us.ibm.com; hfinkel at anl.gov; acjacob at us.ibm.com; Robinson, Paul
> >> Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target
> >> parallel for simd' pragma
> >>
> >> Hi Paul,
> >> Could you provide a little bit more info about diagnostic you see? Maybe
> >> the tests just need to be fixed
> > That would be fine too.  Log of the two failing tests attached.
> > Thanks,
> > --paulr
> >
> >> Best regards,
> >> Alexey Bataev
> >> =============
> >> Software Engineer
> >> Intel Compiler Team
> >>
> >> 15.07.2016 2:09, Paul Robinson пишет:
> >>> probinson added a subscriber: probinson.
> >>> probinson added a comment.
> >>>
> >>> I'm seeing a different set of diagnostics in two of these tests,
> because
> >> we default to C+11, which makes them fail for us.  Ideally you'd
> >> conditionalize the tests on the value of `__cplusplus` (like Charles Li
> >> has been doing for a whole lot of the Clang tests).  If that's
> >> inconvenient for you right now, would you mind if I added `-std=c++03`
> to
> >> the following tests?  It's just these two that need it:
> >>> target_parallel_for_simd_collapse_messages.cpp
> >>> target_parallel_for_simd_ordered_messages.cpp
> >>>
> >>>
> >>> Repository:
> >>>     rL LLVM
> >>>
> >>> https://reviews.llvm.org/D22096
> >>>
> >>>
> >>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160715/f4dea522/attachment.html>