[PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

Teresa Johnson via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 14 12:35:33 PDT 2016


tejohnson added inline comments.

================
Comment at: lib/CodeGen/BackendUtil.cpp:740
@@ +739,3 @@
+  ComputeCrossModuleImportForModule(M->getModuleIdentifier(), *CombinedIndex,
+                                    ImportList);
+
----------------
mehdi_amini wrote:
> This should go away at some point right?
> Just to double check if my memory is correct: the linker plugin will emit the import decision and the backend will take it as an input instead of recomputing anything?
The way they are passed down is via the individual combined index. So it simply computes via what is in the index, which will only include summaries for what should be imported. I suppose we could make the logic even simpler tho and just blindly import what is in the index. 

Peter, can you add a fixme? 


https://reviews.llvm.org/D21545





More information about the cfe-commits mailing list