[PATCH] D18171: [CUDA][OpenMP] Create generic offload action

Artem Belevich via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 13 16:50:06 PDT 2016


tra added inline comments.

================
Comment at: test/Driver/cuda_phases.cu:1
@@ +1,2 @@
+// RUN: %clang -target powerpc64le-ibm-linux-gnu -ccc-print-phases --cuda-gpu-arch=sm_30 %s 2>&1 \
+// RUN: | FileCheck -check-prefix=BIN %s
----------------
Few words describing the test would be nice to have.

You may also want to add few `REQUIRES` fields so the test does not break for builds w/o PPC or NVPTX.

```
// REQUIRES: clang-driver
// REQUIRES: nvptx-registered-target
// REQUIRES: powerpc-registered-target

```

I wonder if the test need host arch specified at all. I think it should be able to run on any host as long as it supports NVPTX.


http://reviews.llvm.org/D18171





More information about the cfe-commits mailing list