[PATCH] D22073: libc++: test lock-free atomic alignment
Eric Fiselier via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 11 21:39:15 PDT 2016
EricWF added a comment.
- The test should be moved to `test/libcxx/atomics/atomics.align` since it's libc++ specific.
- Please give the anonymous struct declarations unique names. `T1`, `T2`, ..., `TN` is fine. Currently they all mangle to `main::type` in diagnostic output.
- The test fails to link on my machine unless I manually links `-latomic`. The tests currently don't link `-latomic` and I don't want to turn it on by default. I'll try and fix this.
http://reviews.llvm.org/D22073
More information about the cfe-commits
mailing list