[PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

[Alexey Bataev via cfe-commits]

ABataev added a comment.

I don't see successful test for the clause, which prints AST and checks serialization/deserialization. Also it should include a template test to check that dependent objects are handled correctly


================
Comment at: include/clang/AST/OpenMPClause.h:4236
@@ +4235,3 @@
+  friend class OMPClauseReader;
+  /// \brief Build clause with number of variables \a N.
+  ///
----------------
\brief

================
Comment at: include/clang/AST/OpenMPClause.h:4258
@@ +4257,3 @@
+public:
+  /// \brief Creates clause with a list of variables \a VL.
+  ///
----------------
\brief

================
Comment at: include/clang/AST/OpenMPClause.h:4269
@@ +4268,3 @@
+         SourceLocation EndLoc, ArrayRef<Expr *> VL);
+  /// \brief Creates an empty clause with the place for \a N variables.
+  ///
----------------
\brief

================
Comment at: lib/Sema/SemaOpenMP.cpp:11648
@@ +11647,3 @@
+    // item should be a pointer or reference to pointer
+    if (!Type.getNonReferenceType()->isPointerType()) {
+      Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
----------------
What if Type is dependent?


Repository:
  rL LLVM

http://reviews.llvm.org/D21904