[PATCH] D22102: [clang-rename] extend testset

Manuel Klimek via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 11 04:16:49 PDT 2016


klimek added a comment.

Add
// FIXME: <desired behavior to implement>
to tests that do not work yet.

I'd personally not check in the XFAIL tests for now, and just add them when you implement the missing functionality; the problem with XFAIL here is that (due to the offsets involved) they can easily switch into a mode where they fail not because the feature is not implemented, but because the test is incorrect.


http://reviews.llvm.org/D22102





More information about the cfe-commits mailing list