r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

[Reid Kleckner via cfe-commits]

On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Yeah - is this necessary for CodeView? (does something break, or do you
> just get simple names where you'd prefer full mangled or qualified names)
>
> It was chosen pretty deliberately to do it this way (use unqualified
> names) for gmlt to keep size down. Have you got numbers for the size delta
> for CodeView with this change? I'd really prefer to make the same choice
> for both - it'd seem a bit arbitrary to choose our size optimization based
> on differences in the kind of workloads we happen to have on these two
> platforms.
>

It's problematic for CodeView because there is no equivalent field like
DW_AT_linkage_name in any of the symbol records. There is only the display
name, which includes scope qualifiers.

I'm suggesting we reverse our decision for DWARF because our space saving
optimization breaks standard stack dumpers on Linux (gdb and addr2line),
and that seems like a Bad Thing. Instead we've told users to user
llvm-symbolizer, which is OK, but kind of crappy. For CodeView, because the
linkage name isn't present anywhere, we can't actually do any better with
llvm-symbolizer, and we need the fully scoped name.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20160707/b25dea61/attachment.html>