[PATCH] D21814: clang-rename: support multiple renames with one invocation

[Kirill Bobyrev via cfe-commits]

omtcyf0 added a comment.

Manuel,

> I think it's important to note that Miklos is probably a user, otherwise I'd guess he wouldn't add those features.


Sure. But there are different kinds of users :) IIRC there's a discussion in cfe-def called "Clang should natively support Fortran" or something. Not saying it's bad, but needs of different users may seem strange to the others.

> Generally, we also internally have a (large scale) simplified rename tool that allows renaming multiple things in a code base at once; it is definitely a useful tool to have.


Hm, I see. So if that's an often used scenario I'm all for it :)

> Perhaps we can make this better by doing the following compromise:

>  Instead of just having tons of parameters where it's hard to say which parameter does what, have 2 different commands that you can call, each with their own set of flags:

>  clang-rename rename-at -offset ... -newname ...

>  clang-rename rename-all -oldname ... -newname ... -oldname ... -new-name ... (or similar)


This is probably similar to:

> At the end I think we can both be happy if we separate the CLI and the renaming interface completely. The editors can interact with a C++ Library then and clang-rename would become a command line interface with many options to that library


So I guess I can probably get to that if this seems reasonable to you. I'd be happy to have a pure and clear interface, which won't deal with wrong user input etc.

Thanks for the feedback!


http://reviews.llvm.org/D21814