[PATCH] D22087: [clang-rename] add basic vim integration

Kirill Bobyrev via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 7 05:23:30 PDT 2016


omtcyf0 added a comment.

Yup. FeelsBadMan.

One note about that header removal: how do I do it then? I thought attaching such changes to a random patch is not a problem. Otherwise there will be some one-line patches for such things, won't they?


================
Comment at: clang-rename/tool/ClangRename.cpp:39
@@ -38,3 +38,2 @@
 #include "llvm/Support/Host.h"
-#include <cstdlib>
 #include <string>
----------------
bkramer wrote:
> This looks unrelated.
Right, but I'm not sure one-line patches are welcome.

Is it not alright to put such into random patches? Otherwise creating one-liner...


http://reviews.llvm.org/D22087





More information about the cfe-commits mailing list