[PATCH] D21603: [include-fixer] Add missing namespace qualifiers after inserting a missing header.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 7 02:17:54 PDT 2016
hokein added inline comments.
================
Comment at: unittests/include-fixer/IncludeFixerTest.cpp:144
@@ -141,1 +143,3 @@
+ runIncludeFixer("a::b::foo bar;\n",
+ /*FixNamespaceQualifiers=*/true, IncludePath));
----------------
djasper wrote:
> I think we should set this to true everywhere or more precisely completely remove this parameter. Now that the flag is gone, we are starting to test implementation details IMO.
Yeah, this parameter is not needed. Removed it.
http://reviews.llvm.org/D21603
More information about the cfe-commits
mailing list