[PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

[Mehdi AMINI via cfe-commits]

mehdi_amini added inline comments.

================
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX.  The runtime
+archive is distributed under the ``build/lib/clang/<VERSION>/lib/<OS>``
----------------
bruening wrote:
> mehdi_amini wrote:
> > bruening wrote:
> > > This should not be necessary: as mentioned above, if -fcsi is passed to the link line you should be able to have clang automatically add the static csi library, just like is done for the sanitizers.
> > This is not clear to me: the sanitizers are auto-linking the clang supplied runtime. Here it seems to be about a user-supplied library.
> No, the CSI runtime is not the user-supplied part: it is part of the clang build, just like the sanitizer runtime libraries (see line 79 below showing where it lives).  The user-supplied part is "my-tool.o".
Oh you're totally right, I thought you were referencing the tool-specific implementation.


Repository:
  rL LLVM

http://reviews.llvm.org/D21753