[PATCH] D17990: [clang-tidy] minor improvements in modernise-deprecated-headers check
Alexander Kornienko via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 6 06:27:43 PDT 2016
alexfh added inline comments.
================
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:39
@@ +38,3 @@
+* `<string.h>` -> `<cstring>`
+* `<tgmath.h>` -> `<ctgmath>` // deprecated since C++11
+* `<time.h>` -> `<ctime>`
----------------
alexfh wrote:
> Not sure if "deprecated" is the right word here. The wording seems to be slightly different: "This header simply includes <cmath> and <ccomplex>."
What about this comment? (was on the' <tgmath.h> -> <ctgmath>` line)
================
Comment at: docs/clang-tidy/checks/modernize-deprecated-headers.rst:41
@@ +40,3 @@
+* `<time.h>` -> `<ctime>`
+* `<uchar.h>` -> `<cuchar>` // deprecated since C++11
+* `<wchar.h>` -> `<cwchar>`
----------------
alexfh wrote:
> It's not exactly "deprecated". It has appeared in C++11 and is not particularly useful (just contains a couple of feature macros). Maybe we should just remove #includes of this header as well.
What about this comment? (was on the' <uchar.h> -> <cuchar>` line)
http://reviews.llvm.org/D17990
More information about the cfe-commits
mailing list