[PATCH] D21904: [OpenMP] Initial implementation of parse+sema for clause use_device_ptr of 'target data'

[Alexey Bataev via cfe-commits]

ABataev added inline comments.

================
Comment at: include/clang/AST/OpenMPClause.h:4221
@@ +4220,3 @@
+
+/// \brief This represents clause 'use_device_ptr' in the '#pragma omp ...'
+/// directives.
----------------
No \brief's

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333
@@ -8332,1 +8332,3 @@
   "expected at least one 'to' clause or 'from' clause specified to '#pragma omp target update'">;
+def  err_omp_usedeviceptr_not_a_pointer : Error<
+  "item used in 'use_device_pointer' clause is not a pointer">;
----------------
I think it 's better to use 'expected ...' form as in other errors/warnings

================
Comment at: include/clang/Sema/Sema.h:8466
@@ -8465,1 +8465,3 @@
                                    SourceLocation EndLoc);
+  /// \brief Called on well-formed 'use_device_ptr' clause.
+  OMPClause *ActOnOpenMPUseDevicePtrClause(ArrayRef<Expr *> VarList,
----------------
No \brief

================
Comment at: lib/Sema/TreeTransform.h:1784
@@ -1783,1 +1783,3 @@
 
+  /// \brief Build a new OpenMP 'use_device_ptr' clause.
+  ///
----------------
Remove \brief tag


Repository:
  rL LLVM

http://reviews.llvm.org/D21904