[PATCH] D21936: [clang-tidy] UnnecessaryValueParamCheck - only warn for virtual methods

Felix Berger via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 5 07:42:38 PDT 2016


flx added inline comments.

================
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:234
@@ +233,3 @@
+};
+
+struct PositiveNonVirualMethod {
----------------
alexfh wrote:
> Please add a test for an override not explicitly marked "virtual" or "override".
That case is already covered in line 180. I moved these tests up now to have them grouped together.


http://reviews.llvm.org/D21936





More information about the cfe-commits mailing list