[PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

Justin Lebar via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 1 00:31:16 PDT 2016


jlebar added a subscriber: jlebar.
jlebar added a comment.

Yeah, I'd say that in the absence of a rule, consistency with surrounding
code is king.  Otherwise we're sending a message when we don't mean to be.

I'm not at my machine, but my recollection is that most of the driver uses
final sparingly.  But whatever the convention is we should do that, I think.


http://reviews.llvm.org/D18172





More information about the cfe-commits mailing list